aarch64: Fix cmp_x0,155/cmp_x0,154 incorrect defines#116
Merged
stikonas merged 1 commit intooriansj:mainfrom Mar 18, 2026
Merged
aarch64: Fix cmp_x0,155/cmp_x0,154 incorrect defines#116stikonas merged 1 commit intooriansj:mainfrom
stikonas merged 1 commit intooriansj:mainfrom
Conversation
``` .global _start _start: cmp x0,154 cmp x0,155 ``` ``` /tmp/main-aarch64: file format elf64-littleaarch64 Disassembly of section .text: 0000000000400078 <_start>: 400078: f102681f cmp x0, #0x9a 40007c: f1026c1f cmp x0, #0x9b ```
stikonas
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At some point™ I'll look into automatically verying the defines.
@stikonas @oriansj