Added TLS for port range 2434-2440#237
Merged
wolf4ood merged 6 commits intoorientechnologies:masterfrom Mar 15, 2017
Merged
Conversation
added TLS socket for TLS connections
added TLS dependency
1 similar comment
because it complains about it already being declared...
undid changes, bloody complier
Author
|
Sorry about the updates. I was just seeing if i could make the checks happy, which never seems to happen... |
1 similar comment
wolf4ood
requested changes
Mar 9, 2017
Member
wolf4ood
left a comment
wolf4ood
left a comment
There was a problem hiding this comment.
hi @RyanTopps
thanks for this PR.
i think bringing var socket; outside the if and the return socket statement at the end should solve it
final fix hopefully
Author
|
updated |
Member
|
Thanks |
wolf4ood
added a commit
that referenced
this pull request
Mar 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added TLS in connection.js for ports 2434-2440 as documented for SSL in orientdb. I tested it and it works fine. I have also added the dependency in project.json.