Skip to content

It should be possible to skip findAndRegisterModules in JacksonSnapshotSerializer #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackmatt2 merged 2 commits into from
Feb 12, 2023
Merged

It should be possible to skip findAndRegisterModules in JacksonSnapshotSerializer #148

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d819ba
make findAndRegisterModules skip-able by a custom impl
xtermi2 Feb 10, 2023
6580470
Update SnapshotHeaders.java
jackmatt2 Feb 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ...c/main/java/au/com/origin/snapshots/jackson/serializers/v1/JacksonSnapshotSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ public DefaultPrettyPrinter withSeparators(Separators separators) {
this.disable(SerializationFeature.FAIL_ON_EMPTY_BEANS);
this.setSerializationInclusion(JsonInclude.Include.NON_NULL);

this.findAndRegisterModules();
if (shouldFindAndRegisterModules()) {
this.findAndRegisterModules();
}

this.setVisibility(
this.getSerializationConfig()
Expand All @@ -69,6 +71,14 @@ public DefaultPrettyPrinter withSeparators(Separators separators) {
*/
public void configure(ObjectMapper objectMapper) {}

/**
* Override to control the registration of all available jackson modules within the classpath
* which are locatable via JDK ServiceLoader facility, along with module-provided SPI.
*/
protected boolean shouldFindAndRegisterModules() {
return true;
}

@Override
public Snapshot apply(Object object, SnapshotSerializerContext gen) {
try {
Expand Down