chore(config): dedup CONFIG_PATH + fix misleading legacy labels#161
Merged
KailasMahavarkar merged 1 commit intomainfrom Apr 20, 2026
Merged
chore(config): dedup CONFIG_PATH + fix misleading legacy labels#161KailasMahavarkar merged 1 commit intomainfrom
KailasMahavarkar merged 1 commit intomainfrom
Conversation
Two unrelated config-layer cleanups: 1. One CONFIG_PATH, not two tools/autoresearch/providers.py and tools/autoresearch/run_loop.py each computed Path(__file__).parent / "config.json" independently (under two different names, _CONFIG_PATH and CONFIG_FILE). Promoted to providers.CONFIG_PATH and aliased as CONFIG_FILE in run_loop via import so both files point at the same constant now. Also added a docstring on providers.load_config clarifying it is the one-shot variant (use run_loop.load_config for the autoresearch long-running mtime-cached + migrated variant). 2. "legacy kwargs" labels were wrong config.merge_kwargs and store.py both called GraphStore(embedder=...), ingest_root=..., vault=..., retention=... "legacy" kwargs. They are in fact the primary public API - every test + docs page uses them. Relabeled as "top-level convenience kwargs" so future reviewers do not incorrectly conclude they are removable. No functional change. 27 tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two unrelated config-layer cleanups caught during a deeper poison audit.
1. One CONFIG_PATH, not two
tools/autoresearch/providers.pyandtools/autoresearch/run_loop.pyeach computed the same path independently (under two different names,_CONFIG_PATHandCONFIG_FILE). Promoted toproviders.CONFIG_PATHand aliased asCONFIG_FILEinrun_loopvia import, so both files point at the same constant now.Also added a docstring on
providers.load_configclarifying it's the one-shot variant - userun_loop.load_configfor the autoresearch long-running mtime-cached + migrated variant.2. "legacy kwargs" labels were wrong
config.merge_kwargsandstore.pyboth calledGraphStore(embedder=...),ingest_root=...,vault=...,retention=..."legacy" kwargs. They are in fact the primary public API - every test + doc uses them.Relabeled as "top-level convenience kwargs" so future reviewers don't incorrectly conclude they're removable.
Test plan
🤖 Generated with Claude Code