feat: corpus-back golang practice loader + 3 P0 concurrency/error practices#88
Merged
KailasMahavarkar merged 4 commits intomainfrom Apr 21, 2026
Merged
Conversation
Adds corpus support to `src/plugins/golang/tools/get-practice.ts`. Tool now reads per-practice slices from `corpus/backend/golang/<name>.yaml`, validates required fields (topic, priority, rule, reason), and falls back to the in-file BEST_PRACTICES registry when the corpus entry is missing or invalid. Creates the golang corpus namespace (first backend domain): - `corpus/backend/golang/index.yaml` registers the `backend.golang` namespace and practice files - `corpus/backend/golang/error-wrapping.yaml` captures the P0 error-wrapping practice (fmt.Errorf with %w, good/bad examples) - `corpus/index.yaml` registers the new namespace New `tests/golang-practice-corpus-backed-tools-behaviour.test.ts` asserts corpus source for error-wrapping and fallback for goroutine-lifecycle. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds corpus/backend/golang/goroutine-lifecycle.yaml with ctx.Done() exit pattern and unbounded jobCh anti-pattern. Registers goroutine-lifecycle in namespace index. Test asserts corpus source for goroutine-lifecycle; fallback check moves to context-first-param. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds corpus/backend/golang/context-first-param.yaml with ctx.Context first-param rule, good/bad signatures. Registers context-first-param in namespace index. Test asserts corpus source for context-first-param; fallback check moves to handle-once. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/plugins/golang/tools/get-practice.tswith a generic per-practice loader (validates name/topic/priority/rule/reason) that falls back to the in-file BEST_PRACTICES registry when the slice is missingbackend.golangcorpus namespace (first backend domain)backend.golangincorpus/index.yamltests/golang-practice-corpus-backed-tools-behaviour.test.tsasserts corpus source for every migrated practiceTest plan