feat(merger): path-relative resolution — ork run/validate works from any directory#157
Merged
Conversation
…elative to declaring file
…pendency moved to setup block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg/merger/file.go:crdFile,crFiles,setup.apply, and Komposerimports.filesare now resolved relative to the declaring file, not the working directorycmd/cli/files.go: CLI-provided-fpaths are converted to absolute on intake so downstream resolution is always anchored correctlyexamples/use-cases/full-stack-app: all six sub-katalogs switched fromapiTypes:tocrdFile:— manualkubectl apply -f crd.yamlpre-step eliminated from every walkthrough03-cross-crd/crd.yamlsplit intocrd-managed-database.yaml+crd-database-backed-app.yaml;06-full-stackusessetup:block to pull in the managed-database dependencyTest plan
ork run -f /absolute/path/katalog.yamlworks from any directoryork run(no-f) still resolves CRDs from the current directoryork e2eon 03-cross-crd passes with split CRD filesork e2eon 06-full-stack applies managed-database via setup block without a manual pre-step