fix: drop unmentioned related columns from values()/values_list()#1669
Merged
Conversation
Merging this PR will degrade performance by 29.25%
Performance Changes
Comparing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #800.
values()/values_list()were leaking columns of related models that got pulled into the query by a filter (e.g.filter(project__id=...)) or a bareselect_related()but were never named infields(). The flat-projection result included every column of the joined model on top of what the caller actually requested.The fix adds
ExcludableItems.with_projection_exclusions(source_model, select_related), called fromQuerySet.values(). Whenfields()was used, it walks each select_related path and adds an implicit exclude for any segment (and its m2m through model) the user never referenced. Regular ORM-load queries (get,all, etc.) are unchanged - they still load all columns of unmentioned related models so Pydantic construction does not lose mandatory fields.