Handle non-standard second-level domains in getRootDomain#37
Merged
Handle non-standard second-level domains in getRootDomain#37
getRootDomain#37Conversation
Co-authored-by: ormidales <46538211+ormidales@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix parser failure for non-standard second-level domains
Handle non-standard second-level domains in Feb 16, 2026
getRootDomain
ormidales
approved these changes
Feb 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates getRootDomain’s ccTLD handling to correctly extract registrable domains for additional second-level domain patterns (e.g., .asso.fr), improving whitelist targeting and redirect-domain comparisons across more real-world ccTLD structures.
Changes:
- Expanded
secondLevelSuffixesinutils.jsto includeasso,gouv, andnom. - Preserved existing behavior for previously supported patterns (e.g.,
co.uk,com.au).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| const secondLevelSuffixes = new Set(["ac", "co", "com", "edu", "gov", "net", "org"]); | ||
| const secondLevelSuffixes = new Set(["ac", "asso", "co", "com", "edu", "gov", "gouv", "net", "nom", "org"]); |
There was a problem hiding this comment.
secondLevelSuffixes is instantiated on every getRootDomain call. Consider hoisting it to a module-level constant (e.g., const SECOND_LEVEL_SUFFIXES = new Set([...])) to avoid repeated allocations and make future updates easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getRootDomainrelied on a narrow hardcoded second-level suffix set, which caused incorrect root extraction for domains likemon-site.asso.fr(returned asasso.fr). This impacted whitelist targeting and redirect-domain comparison for ccTLD patterns outside the original list.Domain parsing update (
utils.js)secondLevelSuffixesused bygetRootDomainto recognize additional second-level labels used with 2-letter TLDs:asso,gouv,nomco.uk,com.au) remains unchanged.Behavioral impact
.asso.frcase.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.