Conversation
…round.js Co-authored-by: ormidales <46538211+ormidales@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix internal protocol interception errors in background script
Exclude internal browser protocols from webRequest interception
Feb 28, 2026
ormidales
approved these changes
Feb 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents the extension’s background.js webRequest handlers from processing internal/non-web URLs by adding an early-exit guard for non-http:// / non-https:// schemes, avoiding unnecessary work and URL/hostname edge cases.
Changes:
- Add a scheme guard in
onBeforeRequestto skip non-HTTP(S) main-frame URLs before attempting hostname tracking. - Add the same guard in
onBeforeSendHeadersto avoid header mutation work for non-HTTP(S) URLs. - Add the same guard in
onHeadersReceivedto skip redirect processing for non-HTTP(S) URLs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The background script's
webRequestlisteners were firing on internal browser URLs (about:blank,moz-extension://, etc.), which have no standard hostname — causing silent try/catch failures and unnecessary CPU usage.Changes
onBeforeRequest,onBeforeSendHeaders,onHeadersReceived: Added an early-exit guard immediately after themain_frametype check to skip any URL that isn'thttp://orhttps://Uses explicit scheme prefixes (
http:///https://) rather than the looserstartsWith("http")to avoid unintended matches.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.