fix(a11y): restore keyboard focus after addCurrentDomain#90
Merged
Conversation
…lock Co-authored-by: ormidales <46538211+ormidales@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix accessibility focus loss after adding domain
fix(a11y): restore keyboard focus after addCurrentDomain
Mar 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an accessibility regression in the popup UI where disabling the “Add” button during addCurrentDomain can cause keyboard focus to be lost, disrupting keyboard navigation and screen reader flow.
Changes:
- Restores a predictable focus target after
addCurrentDomaincompletes by focusing the#statuselement in thefinallyblock. - Ensures
#statusis programmatically focusable by addingtabindex="-1"when missing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabling the "Add" button at the start of
addCurrentDomainimmediately drops browser focus to the top of the DOM, breaking keyboard navigation and screen readers.Changes
popup.js—addCurrentDomainfinallyblock: after re-enabling the button, programmatically move focus to#status, which always holds a meaningful message (success or error) at that pointPlacing the logic in
finallyensures all exit paths — success, duplicate, no-domain, storage error — restore focus consistently. Pattern mirrors existing focus management inclearDomains.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.