Skip to content

implement ORStackViewController #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2015
Merged

implement ORStackViewController #31

merged 2 commits into from
May 5, 2015

Conversation

@delebedev
Copy link
Contributor

Implements #9

orta
orta reviewed May 5, 2015
View reviewed changes
Classes/ios/ORStackViewController.m
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this automate some of the top layout guide?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how it should be handled inside ORStackViewController, for example, for handling bottom bar in this PR I've used self.edgesForExtendedLayout = UIRectEdgeNone; inside sibling view controller and I thought it was correct approach of doing this. (at least I've did this for UITableViewController and it worked as expected)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, this makes sense. 👯

@orta
Copy link
Owner

orta commented May 5, 2015

Awesomeeeeee

@orta
Copy link
Owner

orta commented May 5, 2015

Looks like the fail is legit on CI ( it's a snapshot on the ORSecondViewController ) any chance you can take a quick look? I'm on a computer all day, one this is in I'll release 3.0.0 👍

@delebedev
Copy link
Contributor Author

@orta sure I will

@delebedev
Copy link
Contributor Author

As it appears test never lie 😄 Now controller handles layout guides correctly and tests should pass.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.96%) to 63.33% when pulling 4011bed on garnett:orstackviewcontroller into ebba5be on orta:master.

@orta
Copy link
Owner

orta commented May 5, 2015

aceeeeeee

orta added a commit that referenced this pull request May 5, 2015
@orta
Merge pull request #31 from garnett/orstackviewcontroller
9694a9e 
implement ORStackViewController
@orta orta merged commit 9694a9e into orta:master May 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@delebedev @orta @coveralls