Fix 188/revisit lifetimes #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erence with a specific lifetime
hasezoey
approved these changes
Dec 6, 2025
Contributor
hasezoey
left a comment
hasezoey
left a comment
There was a problem hiding this comment.
Looks great, just some style nitpicks.
Co-authored-by: hasezoey <hasezoey@gmail.com>
Co-authored-by: hasezoey <hasezoey@gmail.com>
Co-authored-by: hasezoey <hasezoey@gmail.com>
Co-authored-by: hasezoey <hasezoey@gmail.com>
Co-authored-by: hasezoey <hasezoey@gmail.com>
Co-authored-by: hasezoey <hasezoey@gmail.com>
Owner
Author
|
@hasezoey thanks a lot for the detailed review. Will merge this PR after completing the changes in selfref-col. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lifetimes of
selfreferences ofNodeRefandNodeMutmethods are revised.Tests are added to make sure that expected code blocks compile: https://github.com/orxfun/orx-tree/blob/fix-188/revisit-lifetimes/tests/iterator_lifetimes.rs.
The fixes mostly break the dependency of the node reference and an iterator created from the node reference. Instead, the returned values lifetime is bound to the lifetime of the tree. Similar fixes are made for lifetime dependencies to the traversers.
Fixes #188