Conversation
zepatrik
force-pushed
the
feat/hydra-cli
branch
from
7b480c3 to
d09c210
Compare
zepatrik
force-pushed
the
feat/hydra-cli
branch
from
d09c210 to
0ca4130
Compare
hperl
approved these changes
Oct 10, 2022
Contributor
hperl
left a comment
hperl
left a comment
There was a problem hiding this comment.
I really like the refactoring! I left two minor questions & comments, but LGTM!
| "github.com/ory/x/cmdx" | ||
| ) | ||
|
|
||
| func wrapHydraCmd(newCmd func() *cobra.Command) *cobra.Command { |
Contributor
There was a problem hiding this comment.
Nit, should this go into client.go?
|
|
||
| func NewIntrospectCmd() *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "introspect", |
Contributor
There was a problem hiding this comment.
Would the more general verb describe also make sense here? I'd imagine that describe would fit more objects than introspect, if we want to follow the kubectl model. But I don't know the semantics for sure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.