docs: document new events LoginStarted and RegistrationStarted#2144
Merged
docs: document new events LoginStarted and RegistrationStarted#2144
Conversation
|
|
vinckr
approved these changes
May 6, 2025
gaultier
force-pushed
the
pgaultier-feat-add-event-login-registration
branch
from
b75b2a3 to
88e65ad
Compare
gaultier
force-pushed
the
pgaultier-feat-add-event-login-registration
branch
from
88e65ad to
a47432c
Compare
gaultier
added a commit
to ory/kratos
that referenced
this pull request
May 7, 2025
<!-- This text will be used for the merge commit. Please read https://www.notion.so/Merging-PRs-998760750c5740debdb6d7ea1661ac01 --> **Changes:** - Add `LoginStarted` and `RegistrationStarted` events along their required attributes - Sort all event attributes alphabetically - Emit these events when a new login/registration flow is created, *after* basic validation passed - It is unclear yet how many of these events will be emitted, as such it is suggested that in a first phase, they remain internal and are not yet sent externally to avoid surprises (note: sometimes, these events can be emitted without user action such as simply visiting/being redirected to the sign-in page, etc) **Documentation PR:** [ory/docs#2144](ory/docs#2144) **Issue:** ory-corp/cloud#7895 <!-- Dependency update: https://github.com/ory/{repo}/compare/{old-commit-hash}...{new-commit-hash} --> Examples in Grafana: - LoginStarted: <img width="955" alt="Screenshot 2025-05-06 at 14 54 32" src="https://github.com/user-attachments/assets/f066f0a7-4b03-4f71-b6e9-385c3f772425" /> - RegistrationStarted: <img width="953" alt="Screenshot 2025-05-06 at 14 46 17" src="https://github.com/user-attachments/assets/e4e07f59-ecbb-4bfb-a01e-72412adca2f5" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue or Design Document
https://github.com/ory-corp/cloud/issues/7895
Implementation: ory/kratos#4404
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
Further comments