fix(docs): fix links to toSession
#2151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the page https://www.ory.sh/docs/identities/session-to-jwt-cors/, right after the sentence `Great! Everything is set up! Let's convert an Ory Session to a JWT:`, when we click on the `REST API` tab, the link `For more details see the [API documentation](https://www.ory.sh/docs/identities/reference/api#tag/frontend/operation/toSession).` leads to a 404. This PR fixes it and makes all links to `toSession` relative per the guidelines in the README. Note 1: There are still ~200 or so links referring directly to `ory.sh/docs` instead of being relative. But this is a big task to update them all so I did not. Note 2: `npm build` does detection of broken links but it did not catch this issue because the link actually points to an [existing file](https://github.com/ory/docs/blob/cf3c62ccc66dc4eb417c4aed13823778284c1949/docs/reference/api.mdx#L1-L1), just not the right one.
vinckr
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the page https://www.ory.sh/docs/identities/session-to-jwt-cors/, right after the sentence
Great! Everything is set up! Let's convert an Ory Session to a JWT:, when we click on theREST APItab, the linkFor more details see the [API documentation](https://www.ory.sh/docs/identities/reference/api#tag/frontend/operation/toSession).leads to a 404.This PR fixes it and make all links to
toSessionrelative per the guidelines in the README.Note 1: There are still ~200 or so links referring directly to
ory.sh/docsinstead of being relative. But this is a big task to update them all so I did not.Note 2:
npm builddoes detection of broken links but it did not catch this issue because the link actually points to an existing file, just not the right one.Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
Further comments