Skip to content

Conversation

@jaygiang
Copy link
Collaborator

Removed CanonicalUrl component and all references. Setting trailingSlash: false in docusarus has resolved the Canonical issue that was merged in this PR.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.com) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Note for @unatasha8: I'm removing this from all index.mdx which I added a month ago to fix SEO issues with Canonicals, but with the recent update, this is no longer needed. This change will not affect how index.mdx behaves and your plans to restructure.

@jaygiang jaygiang requested a review from jonas-jonas November 21, 2025 23:13
@jaygiang jaygiang requested a review from unatasha8 November 21, 2025 23:13
@jaygiang jaygiang changed the title Fix/remove canonical function and references fix: remove canonical function and references Nov 21, 2025
@jaygiang jaygiang changed the title fix: remove canonical function and references chore remove canonical function and references Nov 21, 2025
@jaygiang jaygiang changed the title chore remove canonical function and references chore: remove canonical function and references Nov 21, 2025
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚢

@vinckr vinckr merged commit 8c6f978 into master Nov 24, 2025
9 checks passed
@vinckr vinckr deleted the fix/remove-canonical-function-and-references branch November 24, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants