Skip to content

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Apr 21, 2022

  • adds a spellcheck for US spelling to the CI, checks only .md/.mdx files in /docs.
  • it does not fail when there is mistakes, but we should change that once the current misspellings are fixed.

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added necessary documentation within the code base (if
    appropriate).

Further comments

@vinckr vinckr marked this pull request as ready for review April 21, 2022 14:33
Copy link
Contributor

@tomekpapiernik tomekpapiernik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It's gonna be a nice addition to this repo :)

@aeneasr aeneasr merged commit 19e0075 into master Apr 22, 2022
@aeneasr aeneasr deleted the spellcheck branch April 22, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants