-
-
Notifications
You must be signed in to change notification settings - Fork 277
feat: add relabeling and metricRelabeling in serviceMonitor for all helm charts #804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add relabeling and metricRelabeling in serviceMonitor for all helm charts #804
Conversation
|
Example: values.yaml Output: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there!
Some housekeeping before we can merge this :)
- Please create at least 1 new test values overrides file (in
hacks/values/app) that will have some relabeling set, so that the CI can generate a serviceMonitor with the fields set - Please run
make helm-docsto update chart readme with the new values
Hi! I followed your feedback, but instead of creating a new values override file, I added the relabeling example directly to the default values. Since the change is small and doesn’t introduce much complexity, I thought it might be simpler to keep it in the default file rather than maintaining an extra override file. Would you be okay with that approach, or do you prefer that I still create a separate file under hacks/values/app? Regards! |
|
I am ok with setting that in the default values :) I see that the CI fails when installing postgres 🤔 will check that when i can, as possibly the overrides needs to be updated for the db |
Add relabeling and metricRelabeling for all helm charts
This pull request updates all Helm charts to support feat-relabeling and metric relabeling.
It introduces new configuration options that allow users to customize relabeling rules for Prometheus metrics
across all charts in a consistent way.
Fix: #805
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
Further comments