Fix worker error reporting when asset cannot be found #963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm pretty sure my change shouldn't cause that failure. |
Contributor
|
that's what QA always says |
I introduced a problem in baac24b by using `locate_asset` here. Previously when the asset wasn't found, the variable (`$iso` or whatever) would be the path where we were looking for it; now, it's undef. So the error message won't tell us what asset it was looking for, and additionally we get a (non-fatal) perl error constructing the error message. So let's keep the asset filename around for the purpose of creating the error message, and tweak the wording a bit.
okurz
reviewed
Nov 8, 2016
| my $hdd = $job->{settings}->{"HDD_$i"} || undef; | ||
| if ($hdd) { | ||
| $hdd = locate_asset('hdd', $hdd, 1); | ||
| my $hddname = $job->{settings}->{"HDD_$i"} || undef; |
Contributor
Contributor
Author
There was a problem hiding this comment.
yeah, I didn't add that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a problem in baac24b by using
locate_assethere.Previously when the asset wasn't found, the variable (
$isoorwhatever) would be the path where we were looking for it; now,
it's undef, and that actually causes the worker process to error
out trying to produce the error string. So let's keep the asset
filename around for the purpose of creating the error message,
and tweak the wording a bit.