Skip to content

Conversation

@shivaahir158
Copy link
Collaborator

@shivaahir158 shivaahir158 commented Oct 9, 2024

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

  1. Verifies that the modal window displays with the correct title and fields.
  2. Tests that the "Data Rate" and "Width" fields have default values of 3200 and 64.
  3. Makes sure the closeModal function runs when the close button is clicked.
  4. Verifies the onSubmit function is called when the form is submitted.
  5. Confirms the modal window appears in the DOM.

Which part of the code base require a change

  • Frontend: MemoryModal.test.js
  • Backend:
  • Library: <Specify the library name, e.g. npm packages>
  • Plug-in: <Specify the plugin name, e.g. Webpack, jtest>
  • Documentation
  • Regression tests
  • Continuous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break backward-compatibility. If so, please list who may be influenced.

@codecov
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.06%. Comparing base (64152d8) to head (8a9c6c3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
+ Coverage   68.03%   68.06%   +0.03%     
==========================================
  Files         109      109              
  Lines        8527     8527              
==========================================
+ Hits         5801     5804       +3     
+ Misses       2726     2723       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shivaahir158 shivaahir158 marked this pull request as ready for review October 9, 2024 01:04
@shivaahir158 shivaahir158 merged commit 02be836 into main Oct 9, 2024
@shivaahir158 shivaahir158 deleted the task/RPE-126/FE-React-Jest-Test-for-MemoryModal.js branch October 9, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants