Skip to content

Conversation

@chernyee
Copy link
Collaborator

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

Change:

  • Refactor the static power calculation to combine the static power data into component JSON files based on HW Team recommendation.
  • The static power includes: Vcc_aux, Vcc_core (Gearbox HP), Vcc_core (HP I/O), Vcc_hv_aux, Vcc_hp_io (1.2V), Vcc_hp_io (1.5V), Vcc_hp_io (1.8V), Vcc_core (Gearbox HR), Vcc_core (HR I/O), Vcc_hr_aux, Vcc_hr_io (1.8V), Vcc_hr_io (2.5V), Vcc_hr_io (3.3V)

Which part of the code base require a change

  • Frontend:
  • Backend: PowerConfig Clock & Peripheral Modules
  • Library: <Specify the library name, e.g. npm packages>
  • Plug-in: <Specify the plugin name, e.g. Webpack, jtest>
  • Documentation
  • Regression tests
  • Continuous Integration (CI) scripts

@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 24.03846% with 79 lines in your changes missing coverage. Please review.

Project coverage is 69.20%. Comparing base (1baa9bc) to head (1de5057).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
backend/submodule/peripherals.py 15.49% 60 Missing ⚠️
backend/submodule/clock.py 26.08% 17 Missing ⚠️
backend/api/peripherals.py 80.00% 1 Missing ⚠️
backend/submodule/rs_device.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   69.39%   69.20%   -0.19%     
==========================================
  Files         110      110              
  Lines        8682     8674       -8     
==========================================
- Hits         6025     6003      -22     
- Misses       2657     2671      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@shivaahir158 shivaahir158 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the build, and rerun the failed jobs

@ravikiranchollangi
Copy link
Contributor

Please check the build, and rerun the failed jobs

You can re-run as well due to delay timezone differences.

@ravikiranchollangi ravikiranchollangi merged commit 2ce7972 into main Oct 24, 2024
10 of 12 checks passed
@ravikiranchollangi ravikiranchollangi deleted the task/RPE-149/refactor-static-power-calculation-part2 branch October 24, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants