Virgo soc driver atcdmac100 #7
Conversation
rahul-r-shah-pub
left a comment
rahul-r-shah-pub
left a comment
There was a problem hiding this comment.
Some changes and some things to discuss
| examples for andes_v5_ae350 DMA instance | ||
| dma0: dma0@f0c00000 { | ||
| compatible = "andestech,atcdmac300"; |
There was a problem hiding this comment.
| compatible = "andestech,atcdmac300"; | |
| compatible = "andestech,atcdmac100"; |
| }; | ||
|
|
||
| spi0: spi@A0800000 { | ||
| compatible = "andestech,atcspi200"; |
There was a problem hiding this comment.
This file name in the code hierarchy is andestech.atcspi200.yaml, it should be andestech,atcspi200.yaml. Notice the full-stop should be replaced by comma
rahul-r-shah
left a comment
rahul-r-shah
left a comment
There was a problem hiding this comment.
Last of reviews done, couple of changes
samples/hello_world/src/main.c
Outdated
| printf("%s flash has status disabled...%s\n", ATTR_ERR,ATTR_RST); | ||
| } else { | ||
| printf("%s flash Object is Created. Initialize to Test Via DMA%s\n", ATTR_INF,ATTR_RST); | ||
| if(flash != NULL) { |
There was a problem hiding this comment.
Do we need this extra check? Youve already check this above flash == NULL, or do you mean to be checking for DMA here?
There was a problem hiding this comment.
Actually now we dont need it now. Earlier i was doing deferred initialization of flash. There it was needed. that extra initialization line is removed. I will remove this.
drivers/dma/dma_andes_atcdmac100.c
Outdated
|
|
||
| struct __attribute__((packed, aligned(4))) chain_block { | ||
| uint32_t ctrl; | ||
| uint32_t srcaddrl; |
There was a problem hiding this comment.
Hey, whats the 'l' at the end of srcaddr?
There was a problem hiding this comment.
in ATCDMAC300 we have low and high registers. I removed all the srcaddrh type variables and left srcaddrl type. May be i can rename it to remove this l part as well.
Uh oh!
There was an error while loading. Please reload this page.