feat: add e2e testing with playwright#84
Merged
baruchiro merged 16 commits intoos-scar:masterfrom May 28, 2023
Merged
Conversation
Contributor
Author
|
We should add a Readme on how to use playwright and write tests. |
baruchiro
reviewed
May 17, 2023
Collaborator
baruchiro
left a comment
baruchiro
left a comment
There was a problem hiding this comment.
Good start, I just reviewed it a little, it failed when I run it locally, I will try again tomorrow.
Contributor
Author
|
@baruchiro fixed the issues plz let me know if there is anything else |
baruchiro
force-pushed
the
master
branch
2 times, most recently
from
e8eb49b to
aaf39e5
Compare
Collaborator
|
I can't make the lint pipeline work, see lirantal/github-action-new-dependencies-advisor#4 |
ETtestim
commented
May 23, 2023
baruchiro
reviewed
May 23, 2023
Collaborator
There was a problem hiding this comment.
Very good!
As far as I understand, it is not running in headless mode.
- We should add a Readme on how to use Playwright and write tests. (I'm not sure about that. Just ask to run
yarn e2e. Also maybe we will add a PR template to make sure the contributor ran thee2eon its own machine.)
ETtestim
commented
May 26, 2023
| "test:components": "cd tests/components && vite", | ||
| "e2e": "playwright test", | ||
| "e2e:debug": "playwright test --debug", | ||
| "e2e": "yarn build && playwright test", |
Contributor
Author
There was a problem hiding this comment.
@baruchiro just to understand this line why do we need to build it?
Collaborator
There was a problem hiding this comment.
You have to build the extension before running the e2e, right?
See my comment here: #84 (comment)
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added playwright for e2e testing.
it uses real browser and install the extension.
can only run on chrome/ chromium browsers.
headless mode can be just need to research more on how to.
added a example test for npm.
Also added a unique id to the tooltip so we can catch its selector with ease.