DISPLAY-986: Updated add user command to ask which tenants user belongs to

[turegjorup]

Link to ticket

https://jira.itkdev.dk/browse/SUPP0RT-1109

Description

Updated add user command to ask which tenants user belongs to

Screenshot of the result

If your change affects the user interface you should include a screenshot of the result with the pull request.

Checklist

• My code is covered by test cases.
• My code passes our test (all our tests).
• My code passes our static analysis suite.
• My code passes our continuous integration process.

If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

If you have any further comments or questions for the reviewer please add them here.

[rimi-itk]

I would use options for this (rather than arguments) to make it easier to handle multiple values, e.g.

app:user:add … --role=admin --tenant=hat --tenant=briller

but that's a matter of opinion.

[turegjorup]

Generally my preference as well. This was originally adapted from https://github.com/symfony/demo/blob/main/src/Command/AddUserCommand.php

[rimi-itk]

And that example uses an option, --admin, for (implicitly) setting the role. This is not really important, so let's leave it as it is for now.

[turegjorup]

Agreed 😄

Changed because

1. there might be more than 2 roles at some point,
2. none of the people who has had to use the command have figured out the --admin option. So tried to make it more obvious how to select role

[rimi-itk]

I don't understand what “(to select multiple answer with a list. E.g: "key1, key3")” means. Doesn't the helper help the user picking multiple values?

[turegjorup]

No. You have to answer with a list of comma separated values. There is no "UI".

[rimi-itk]

Oh, I thought the terminal presented a checkbox like user experience.

[turegjorup]

https://symfony.com/doc/current/components/console/helpers/questionhelper.html#multiple-choices

use Symfony\Component\Console\Question\ChoiceQuestion;

// ...
public function execute(InputInterface $input, OutputInterface $output): int
{
    // ...
    $helper = $this->getHelper('question');
    $question = new ChoiceQuestion(
        'Please select your favorite colors (defaults to red and blue)',
        ['red', 'blue', 'yellow'],
        '0,1'
    );
    $question->setMultiselect(true);

    $colors = $helper->ask($input, $output, $question);
    $output->writeln('You have just selected: ' . implode(', ', $colors));

    return Command::SUCCESS;
}

[turegjorup]

Notice implode(', ', $colors)

[turegjorup]

But yes, before testing it I also expected a checkbox like feature

[rimi-itk]

For future-proofing you could set these roles in an environment variable. Or at least put the list into a class variable; it's also used in interact.

[turegjorup]

Moved to a class constant.

Originally I tried to get the values through DI and the one of the Security services. Didn't work as I wanted because it's a subset of the defined roles we allow here.

I don't like moving them to env because they would still have to match what is defined in security.yaml. Also I consider env values to be something you can configure. But Symfony's docs encourage you to do stuff like #[IsGranted('ROLE_ADMIN')] in code, so having the roles configurable would clash with that.