fix highlighting of refined flow segments#2305
Merged
philip-alldredge merged 5 commits intomasterfrom May 5, 2020
Merged
Conversation
Contributor
|
@RyanMcilnay Please see the attached project. Highlighting of either of the flow implementation does not work as expected. This does not even account for the flows themselves being refined. It illustrates the possibility that the flow refers to a refined element instead of the base. You probably want to compare the "root" refined element on both sides of the comparisons. |
philip-alldredge
suggested changes
Apr 30, 2020
Contributor
philip-alldredge
left a comment
philip-alldredge
left a comment
There was a problem hiding this comment.
Please see other comment for needed changes.
…_refined_flow_segment_highlighting
Contributor
|
@RyanMcilnay is this ready for another review? |
Contributor
Author
|
@philip-alldredge Yep, it is. |
philip-alldredge
approved these changes
May 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2304 .