2306 ge properties for refined elements#2316
Conversation
|
@RyanMcilnay can you explain what this fixes? The issue isn't very clear about what the problem is. |
|
@philip-alldredge Fixed based on your comments. |
| sc = sc.getRefined(); | ||
| } | ||
|
|
||
| final Subcomponent sc = (Subcomponent) AadlHelper.getRootRefinedElement(ne); |
There was a problem hiding this comment.
I'll try to ignore problems like the fact getTypeOptionsInformation does something different from its name IMHO, which are outside the scope of this issue, I don't believe this fix is what we want.
I'm having trouble understanding why the original code gets the refined element at the start. It would seem that the if statement should be removed. The compatible subcomponent should be based on the containing classifier of the subcomponent(even if it is refined) and if a AbstractSubcomponent is being refined, then it should be changeable to anything.
In short, please avoid getting the refined subcomponent at the start and test.
There was a problem hiding this comment.
@RyanMcilnay sorry I added the last comment after you made changes. I should of taken my own advise and used the review feature.
…_properties_for_refined_elements
|
@philip-alldredge Changes made based on comments are done. |
3 participants
Closes #2306.