Skip to content

Graphical editor API rework and refactoring#2379

Merged
philip-alldredge merged 42 commits intomasterfrom
2336_ge_refactoring
Jul 21, 2020
Merged

Graphical editor API rework and refactoring#2379
philip-alldredge merged 42 commits intomasterfrom
2336_ge_refactoring

Conversation

@philip-alldredge
Copy link
Contributor

@philip-alldredge philip-alldredge commented Jul 8, 2020

Closes #2336

@philip-alldredge
WIP
e496849
@philip-alldredge
Merged BusinessObjectContext and Queryable
6b106dd
@philip-alldredge
Rename and move files between packages. Cleanup. Fix version warnings.
a6cda6c
@philip-alldredge
Refinement to palette contributions.
c9c8c7b 
Palette categories are now contributed using the palette contributor
interface. Renamed palette command provider to palette contributor.
@philip-alldredge
Moving files between packages and API revision.
4d4e7d7 
Replaced tooltip and business object provider API. Revised
GraphicalEditorService. Moved more AADL related classes to packages
under org.osate.ge.aadl2
@philip-alldredge
Improved robustness for extensions. Added stub BusinessObjectHandler.
748c0ec 
Write errors to error log when extension fails to load. Continue.
Added new BusinessObjectHandler interface that will be expanded to
replace DI based API.
@philip-alldredge
WIP. Convert GetGraphicalConfiguration and IsApplicable annotations
84a69cb
@philip-alldredge
Business object handler API conversion WIP. Name API, rename API.
7e26914
@philip-alldredge
Reworked business object deletion API.
a3d309b
@philip-alldredge
Consolidated flow specification(instance) handlers. Moved package.
8cf24f7
@philip-alldredge
Graphical editor fixes and refinments for refactoring.
785c680
@philip-alldredge
WIP
9ba52ed
@philip-alldredge
WIP
72c2abb
@philip-alldredge
Reworked GE referencing extension points
cb1b8ca
@philip-alldredge
Simplified GE declarative reference resolver.
43bffc7
@philip-alldredge
Cleanup reference implementations. Case of references are not preserved.
3e7275d
@philip-alldredge
Update GE references to reflect and persist changes in case. Minor GE
15ac204 
cleanups.
@philip-alldredge
Removed Ge extension service.
ace6036
@philip-alldredge
Cleanup and documentation.
4710bc3
@philip-alldredge
Update documentation
41bf44c
@philip-alldredge
Move some of the AADL specific parts of the GE to the aadl package.
944a419
@philip-alldredge
Cleanup.
2cf8be5
@philip-alldredge
GE cleanups.
bc2316a
@philip-alldredge
Tooltip color fixes.
5cede5e
@philip-alldredge
Merge remote-tracking branch 'origin/master' into 2336_ge_refactoring
10b59e2
@philip-alldredge philip-alldredge self-assigned this Jul 8, 2020
@RyanMcilnay
Copy link
Contributor

RyanMcilnay commented Jul 8, 2020

Some initial problems I am having, as far as testing goes:

  • Creating a feature connection causes a read/write transaction exception, not sure if this is due to my model (I wouldn't think so, but I can send my model if necessary).

  • Creating Subprogram Call Sequences causes a "Unable to determine business object to modify" exception, I think the can create method must be wrong.

  • Creating an Access Connection from a subcomponent within another subcomponent, to a feature that is in the containing impl throws an exception, but should probably not be allowed in the first place. To clarify (hopefully), in my test, I have an impl that contains a subcomponent, and that subcomponent contains another subcomponent. I am creating a connection that is from the impl, to the subcomponent that is two levels deep.

RyanMcilnay
RyanMcilnay reviewed Jul 13, 2020
View reviewed changes
RyanMcilnay
RyanMcilnay previously approved these changes Jul 15, 2020
View reviewed changes
philip-alldredge and others added 5 commits July 20, 2020 08:51
@philip-alldredge
Merge remote-tracking branch 'origin/master' into 2336_ge_refactoring
e428989 
Conflicts:
	ge/org.osate.ge.ba/META-INF/MANIFEST.MF
	ge/org.osate.ge/plugin.xml
	ge/org.osate.ge/src/org/osate/ge/internal/ui/editor/ShowFlowContributionItem.java
	ge/org.osate.ge/src/org/osate/ge/internal/ui/tools/CreateEndToEndFlowSpecificationTool.java
	ge/org.osate.ge/src/org/osate/ge/internal/ui/tools/CreateFlowImplementationTool.java
	ge/org.osate.ge/src/org/osate/ge/internal/util/AadlFlowSpecificationUtil.java
@philip-alldredge
Moved flow editing to different packages.
a5be217
@philip-alldredge
Cleanup
06b9021
@philip-alldredge
Reworked part of new flow tools with intention of simplifying impl.
32369fa
@philip-alldredge
Merge branch 'master' into 2336_ge_refactoring
80198a8
@philip-alldredge
Copy link
Contributor Author

philip-alldredge commented Jul 20, 2020

@RyanMcilnay once this is approved and merged, then we can fine things that slipped through the cracks during the flow editing as part of #2392.

@philip-alldredge philip-alldredge merged commit 57206bc into master Jul 21, 2020
@joeseibel joeseibel mentioned this pull request Jul 21, 2020
Closed
@philip-alldredge philip-alldredge deleted the 2336_ge_refactoring branch October 14, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@RyanMcilnay RyanMcilnay RyanMcilnay approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@philip-alldredge philip-alldredge

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor, cleanup, and rework API for graphical editor

2 participants

@philip-alldredge @RyanMcilnay