Add icon for flow implementation. Display proper icon based on selected#2480
Merged
Add icon for flow implementation. Display proper icon based on selected#2480
Conversation
specification implementation: display flow path, sink or source
Contributor
Author
|
I also changed FlowSink.gif file only because it shows up with white background in dark theme view (all others have transparent background, so they show up with black background). New file also has transparent background to match the others |
lwrage
requested changes
Oct 15, 2020
Contributor
lwrage
left a comment
lwrage
left a comment
There was a problem hiding this comment.
Please add an icon for end to end flow.
Comment on lines
+150
to
+153
| } else if (((FlowImplementationImpl) object).getInEnd() == null) { | ||
| return overlayImage(object, getResourceLocator().getImage("full/obj16/FlowSource")); | ||
| } else if (((FlowImplementationImpl) object).getOutEnd() == null) { | ||
| return overlayImage(object, getResourceLocator().getImage("full/obj16/FlowSink")); |
Contributor
There was a problem hiding this comment.
Add icons for flow source/sink implementation (and I above the line like flow implementation).
| return overlayImage(object, getResourceLocator().getImage("full/obj16/FlowSink")); | ||
| } | ||
|
|
||
| return overlayImage(object, getResourceLocator().getImage("full/obj16/FlowImplementation")); |
Contributor
There was a problem hiding this comment.
For consistency name this file FlowPathImplementation.gif
implementation sink/path/source. Add icon for end to end flow
lwrage
approved these changes
Oct 27, 2020
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add icon for flow implementation. Display proper icon based on selected specification implementation: display flow path, sink or source
Fixes #2440