Skip to content

2442 flow specification/implementation label to include sink, path and source#2522

Merged
lwrage merged 3 commits intomasterfrom
2442_flow_labels
Nov 15, 2020
Merged

2442 flow specification/implementation label to include sink, path and source#2522
lwrage merged 3 commits intomasterfrom
2442_flow_labels

Conversation

@asazonova
Copy link
Copy Markdown
Contributor

fixes #2442

Lutz, if I only change FlowSpecificationItemProvider and FlowImplementationItemProvider, it does not show a change in outline view (that is why I added back code in Aadl2LabelProvider).

@asazonova asazonova requested a review from lwrage November 13, 2020 18:59
@asazonova asazonova self-assigned this Nov 13, 2020
Copy link
Copy Markdown
Contributor

@lwrage lwrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a text(XYZ x) method doesn't exist in Aadl2LabelProvider the text comes from XYZItemProvider.getText() in the edit plugin. I recommend that you step through AnnexAwareDeclarativeLabelProvider.doGetText() to see in detail how this works.

@asazonova asazonova requested a review from lwrage November 13, 2020 20:08
@lwrage lwrage merged commit 85c91ea into master Nov 15, 2020
@lwrage lwrage deleted the 2442_flow_labels branch November 15, 2020 17:43
lwrage added a commit that referenced this pull request Feb 16, 2022
2442 flow specification/implementation label to include sink, path and source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No distinction between flow source/path/sink in outline view

2 participants