blueprint: add After/Before fields to firstboot customizations (HMS-9187)#52
Merged
Conversation
This allows to control the order of firstboot customizations.
thozza
reviewed
Apr 27, 2026
Member
thozza
left a comment
thozza
left a comment
There was a problem hiding this comment.
Thanks. In general, this looks great. I've added a small comment that I'd like to discuss before merging.
lzap
changed the title
lzap
changed the title
thozza
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to control the order of firstboot customizations.
I want to refactor my firstboot refactoring and also add absolute ordering against systemd units. This was a point that @thozza brought up several times. While the initial feedback on firstboot was that this (and everything in general) should be independent of the OS, therefore the assumption that systemd is installed should not be made, I think that the practical approach is to have this. We already heard feedback from Insights customers who want to run this before that and run that after something else.
I am going for slightly vague
beforeandafterand only in the Go comment I admit that this is indeed systemd units, but this does not mean this cannot work with SysV init or pretty much anything else - these are strings and if we choose to support non-systemd OS at any point in time, the user just need to provide different strings.