test: add rhel specific tests #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
commented
Dec 11, 2025
|
|
||
| @pytest.mark.skipif(os.getuid() != 0, reason="needs root") | ||
| @pytest.mark.skipif(not os.getenv("RHEL_REGISTRY_USER"), reason="needs registry secrets") | ||
| def test_rhel_bootc_anaconda_iso(tmp_path): |
Contributor
Author
There was a problem hiding this comment.
Once that is in we could do a smoke test for another bootc rhel container (qcow2) but because there is nothing special there (once its pulled from the repo) it does not add much value except some peace-of-mind maybe?
mvo5
force-pushed
the
fix-anaconda-iso-from-rhel-2
branch
2 times, most recently
from
eb50e9e to
37d844e
Compare
mvo5
changed the title
mvo5
requested review from
bcl,
lzap and
thozza
and removed request for
a team
lzap
previously approved these changes
Dec 12, 2025
bcl
reviewed
Dec 12, 2025
The rhel_test.py was not working before because I (wrongly) assumed that during a merge queue merge the branch would have access to the repository secrets (which IMNSHO would make sense given that the branch was approved and is going into main). But that is not the case so this commit moves to the same pattern we use in bib, i.e. we only allow this to run for people with write permissions to the repo. This means that the inital workflow for external contributors will always fail but when a contributor clicks on retry it will work.
mvo5
force-pushed
the
fix-anaconda-iso-from-rhel-2
branch
from
37d844e to
0d7a2fd
Compare
This commit adds an integration test for the fix that bootc anaconda ISO secrets must be read while the container is mounted.
mvo5
force-pushed
the
fix-anaconda-iso-from-rhel-2
branch
from
0d7a2fd to
a985688
Compare
lzap
approved these changes
Dec 15, 2025
thozza
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an regression/integration test for the bootc anaconda-iso image type for #404. As a by-product it also tweaks the "manifest-is-container" test for rhel that was not quite working before (see the git commit message for details).
Please review extra carefully as this is a pull_request_target PR