Skip to content

Comments

Add pxe-tar-xz to bib types and add boot tests for f43, stream9, and stream10#436

Merged
supakeen merged 6 commits intoosbuild:mainfrom
bcl:main-test-pxe
Jan 22, 2026
Merged

Add pxe-tar-xz to bib types and add boot tests for f43, stream9, and stream10#436
supakeen merged 6 commits intoosbuild:mainfrom
bcl:main-test-pxe

Conversation

@bcl
Copy link
Contributor

@bcl bcl commented Jan 22, 2026

This does what it says in the subject, in several commits of increasing complexity :)

@bcl bcl requested a review from a team as a code owner January 22, 2026 00:08
@bcl bcl requested review from lzap, supakeen and thozza and removed request for a team January 22, 2026 00:08
bcl added 4 commits January 21, 2026 16:17
This allows you to create a bib container that pulls in a local copy of
images by running:

podman build --cache-ttl=1h -f ./devel/Containerfile \
--build-context=images=../images \
-t bootc-image-builder-test .

Set the build container tag environmental variable:
export BIB_TEST_BUILD_CONTAINER_TAG=bootc-image-builder-test

This overrides the container build with the pre-built one (even when
using the same name).

You can now run tests and they will use your development version of bib.
@bcl bcl force-pushed the main-test-pxe branch 2 times, most recently from f8a9468 to ca0d6a7 Compare January 22, 2026 00:56
@supakeen
Copy link
Member

supakeen commented Jan 22, 2026

Mmm, looks generally OK but I think the linter error is cancelling all other tests from running.

I also assume that the boot tests will (eventually) move into images itself once we have bootc-related bits there?

lzap
lzap previously approved these changes Jan 22, 2026
Copy link
Contributor

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: Running bootc status from the booted system currently does not
work so that has been disabled until it has been fixed.

I am wondering what is the error?

@bcl
Copy link
Contributor Author

bcl commented Jan 22, 2026

I also assume that the boot tests will (eventually) move into images itself once we have bootc-related bits there?

They'll follow along with wherever the test/bib/ tests move.

I am wondering what is the error?

[root@localhost ~]# bootc status
[   40.058638] SELinux:  Context unconfined_u:object_r:invalid_bootcinstall_testlabel_t:s0 is not valid (left unmapped).
mount: /sysroot: fsconfig system call failed: overlay: No changes allowed in reconfigure.
       dmesg(1) may have more information after failed mount system call.
error: Status: Opening . with writable mount: Failed to remount: ExitStatus(unix_wait_status(8192))

I'm planning on looking into that next.

bcl added 2 commits January 22, 2026 08:37
This uses QEMU from vmtest, provided by the osbuild/images repository.
It grabs the ostree= kernel cmdline from the grub.cfg in the tarball,
boots qemu with the artifacts and tests that ssh login is successful.

NOTE: Running bootc status from the booted system currently does not
work so that has been disabled until it has been fixed.

The tests include a cmdline option, --keep-tmpdir, that will keep the
pxe-tar-xz tmpdir around after the test runs in order to help with
debugging problems.

Related: HMS-9767
Related: HMS-8933
Copy link
Member

@supakeen supakeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that Fedora updated its linters (which might run downstream) leading to this error there:

# [github.com/osbuild/image-builder-cli/pkg/progress]
./command.go:189:19: non-constant format string in call to (github.com/osbuild/image-builder-cli/pkg/progress.ProgressBar).SetMessagef
FAIL	github.com/osbuild/image-builder-cli/pkg/progress [build failed]

Let's not address that in this PR but let's also not lose track of it. The RHEL-10 failures are PQC/mock related so also not relevant.

Otherwise this PR looks good. Thank you.

@supakeen supakeen added this pull request to the merge queue Jan 22, 2026
Merged via the queue into osbuild:main with commit baf0c22 Jan 22, 2026
35 of 44 checks passed
@bcl
Copy link
Contributor Author

bcl commented Jan 22, 2026

Uh oh. Things got canceled before the new test_build_pxe.py test could run. I'd have liked to see that pass (or mostly work) before merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants