Add pxe-tar-xz to bib types and add boot tests for f43, stream9, and stream10#436
Add pxe-tar-xz to bib types and add boot tests for f43, stream9, and stream10#436supakeen merged 6 commits intoosbuild:mainfrom
Conversation
This allows you to create a bib container that pulls in a local copy of images by running: podman build --cache-ttl=1h -f ./devel/Containerfile \ --build-context=images=../images \ -t bootc-image-builder-test . Set the build container tag environmental variable: export BIB_TEST_BUILD_CONTAINER_TAG=bootc-image-builder-test This overrides the container build with the pre-built one (even when using the same name). You can now run tests and they will use your development version of bib.
f8a9468 to
ca0d6a7
Compare
|
Mmm, looks generally OK but I think the linter error is cancelling all other tests from running. I also assume that the boot tests will (eventually) move into |
lzap
left a comment
There was a problem hiding this comment.
NOTE: Running bootc status from the booted system currently does not
work so that has been disabled until it has been fixed.
I am wondering what is the error?
They'll follow along with wherever the test/bib/ tests move.
I'm planning on looking into that next. |
This uses QEMU from vmtest, provided by the osbuild/images repository. It grabs the ostree= kernel cmdline from the grub.cfg in the tarball, boots qemu with the artifacts and tests that ssh login is successful. NOTE: Running bootc status from the booted system currently does not work so that has been disabled until it has been fixed. The tests include a cmdline option, --keep-tmpdir, that will keep the pxe-tar-xz tmpdir around after the test runs in order to help with debugging problems. Related: HMS-9767 Related: HMS-8933
supakeen
left a comment
There was a problem hiding this comment.
Seems that Fedora updated its linters (which might run downstream) leading to this error there:
# [github.com/osbuild/image-builder-cli/pkg/progress]
./command.go:189:19: non-constant format string in call to (github.com/osbuild/image-builder-cli/pkg/progress.ProgressBar).SetMessagef
FAIL github.com/osbuild/image-builder-cli/pkg/progress [build failed]
Let's not address that in this PR but let's also not lose track of it. The RHEL-10 failures are PQC/mock related so also not relevant.
Otherwise this PR looks good. Thank you.
|
Uh oh. Things got canceled before the new test_build_pxe.py test could run. I'd have liked to see that pass (or mostly work) before merging this. |
This does what it says in the subject, in several commits of increasing complexity :)