LoadAllRepositoriesFromFS: log only filenames of loaded repositories#1070
Merged
thozza merged 2 commits intoosbuild:mainfrom Nov 28, 2024
Merged
LoadAllRepositoriesFromFS: log only filenames of loaded repositories#1070thozza merged 2 commits intoosbuild:mainfrom
thozza merged 2 commits intoosbuild:mainfrom
Conversation
After the rework done by PR#1038 [1], the `configFile` changed from the file path string to `fs.File` instance. As a result, logging it makes the output verbose, as it logs the whole content of the loaded file (repo URLs, GPG keys, etc.). Revert to the old behavior by logging `fileEntry.Name()` for the loaded repository. [1] osbuild#1038 Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Member
Author
Sure, go ahead... 👍 |
This commit adds a tiny test to ensure repo logging does not break again.
mvo5
approved these changes
Nov 28, 2024
Contributor
Updated and approved again, please have a look and merge if this feels okay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the rework done by PR#1038 [1], the
configFilechanged from the file path string tofs.Fileinstance. As a result, logging it makes the output verbose, as it logs the whole content of the loaded file (repo URLs, GPG keys, etc.). Revert to the old behavior by loggingfileEntry.Name()for the loaded repository.[1] #1038