distro: Make isoCustomizations usable by bootcImageType#2360
Merged
Conversation
The function only depends on ISOLabel() and getDefaultISOConfig(). Make it take a new interface, ISOImageType, so that it can be shared between regular images and bootc images. Related: HMS-10627
This satisfies the ISOImageType interface so that isoCustomizations function can be used with bootc image types. Related: HMS-10627
brlane-rht
force-pushed
the
main-iso-custom
branch
from
387d4a5 to
9de2b3c
Compare
supakeen
approved these changes
May 22, 2026
thozza
reviewed
May 25, 2026
Member
thozza
left a comment
thozza
left a comment
There was a problem hiding this comment.
Functionally LGTM, but there is one style / common practice inconsistency.
thozza
approved these changes
May 25, 2026
Member
thozza
left a comment
thozza
left a comment
There was a problem hiding this comment.
I got confused by a struct and method of the same name. All good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function only depends on ISOLabel() and getDefaultISOConfig(). Make it take a new interface, ISOImageType, so that it can be shared between regular images and bootc images.
Related: HMS-10627