Skip to content

Longest contribution streak bug#55

Merged
adavila0703 merged 7 commits intomainfrom
longest-contribution-streak-bug
Dec 12, 2021
Merged

Longest contribution streak bug#55
adavila0703 merged 7 commits intomainfrom
longest-contribution-streak-bug

Conversation

@adavila0703
Copy link
Copy Markdown
Collaborator

@adavila0703 adavila0703 commented Dec 11, 2021

  • Fixed issue where if the longest streak is the current streak, there would be an end date.
  • Added message to handle this new condition
  • Added tests for GetLongestContributionStreakByUsername

Closes #9
Closes #36

Comment thread internal/github/contributions.go Outdated
Comment thread internal/github/contributions.go Outdated
Comment thread internal/github/contributions_test.go Outdated
Comment thread internal/github/contributions_test.go Outdated
Comment thread internal/github/contributions_test.go
Comment thread internal/github/contributions.go Outdated
Comment thread internal/github/contributions.go Outdated
@adavila0703 adavila0703 merged commit 5f764a6 into main Dec 12, 2021
@adavila0703 adavila0703 deleted the longest-contribution-streak-bug branch December 12, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests: GetLongestContributionStreakByUsername Longest contribution streak bug

2 participants