Skip to content

Conversation

@oscarhiggott
Copy link
Owner

Fixes a bug where boundary edges weren't always handled properly when they were a component of an error. i.e. handle_dem_error was called the same on edges and boundary edges:

} else if (num_component_detectors > 0) {
    // If the previous error in the decomposition had 1 or 2 detectors, we handle it
    handle_dem_error(p, {component->node1, component->node2}, component->observable_indices);

This resulted in an exception if the boundary edge was not already in the graph. Also refactors related logic slightly.

@oscarhiggott oscarhiggott requested a review from smadhuk September 5, 2025 21:54
Copy link
Collaborator

@smadhuk smadhuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oscarhiggott oscarhiggott mentioned this pull request Sep 25, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.14%. Comparing base (ae3f212) to head (7fef178).
⚠️ Report is 11 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage   99.15%   99.14%   -0.01%     
==========================================
  Files           3        3              
  Lines         353      351       -2     
==========================================
- Hits          350      348       -2     
  Misses          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oscarhiggott oscarhiggott merged commit 6c33cdb into master Sep 25, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants