PHP 8 support #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 31, 2020 14:05
Note that the test case was altered to work more robustly on both Travis and local environments.
PHP 8 has this setting enabled by default and so this configuration methods is deprecated. The composer.json also explicitly supports PHP 8, and won’t assume ccompatibiliy with PHP 9 if and when that comes out.
Contributor
Author
|
One this is merged, a tag would be appreciated so that it can more easily be pulled in as an embed/embed dependency. |
Owner
|
Great. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a travis.yml and makes a small change necessary for PHP 8 support.
The build can be seen here https://travis-ci.org/github/sminnee/html-parser/builds/722600233 but it would be good to enable travis directly on this repo once this has been merged.