WIP - add PHP 8 support #381
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Looks like this will be blocked by phpspec/prophecy#497 |
added 2 commits
August 31, 2020 13:17
match is a reserved word in PHP8. This function appears to be an internal rather than public API so hopefully renaming it is okay.
Author
|
Once oscarotero/html-parser#1 is merged and tagged I'll look at this again. |
Author
|
Good to know! This is still disrupted by schrodinger's test suite - see #382 |
Collaborator
|
Some time ago, I've removed all test files and regenerated again and now seems like it works fine. At least in my computer and in TravisCI. So maybe we can close #382 |
Contributor
|
Part of this PR has been fixed by a conflicts-free PR based on a fresh master ( |
Collaborator
|
Yes, I think we can close this PR and fix PHP8 issues in different PR. |
Author
|
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.