Change endpoint and update Jest configuration and tests #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvindpunk
requested changes
Nov 16, 2023
|
|
||
| import { generateCronExpression, generateReadableExpression } from '../src/cronGenerator'; | ||
|
|
||
| app.get('/v1/generate', (req, res) => { |
There was a problem hiding this comment.
Do not duplicate server code! (remember, DRY (don't repeat yourself)
Refer to the guide mentioned in jest docs.
arvindpunk
requested changes
Nov 18, 2023
|
|
||
| app.use('/', routes); | ||
|
|
||
| app.listen(port, () => { |
There was a problem hiding this comment.
- export
appfrom this file - in
index.ts, start the actual server by importingappand doingapp.listen(). This allows you to import the app in your test framework for E2E testing as well.
| export function generateReadableExpression(cronExpression: string): string { | ||
| try { | ||
| return cronstrue.toString(cronExpression); | ||
| } catch (error) { |
There was a problem hiding this comment.
Don't try catch here, let it throw error. It should be automatically handled by the global express error catcher and accordingly return an error.
|
|
||
| export function generateCronExpression() { | ||
| function getRandomOrWildcard(min: number, max: number) { | ||
| if (Math.random() < 0.7) { |
There was a problem hiding this comment.
It seems like Math.random cannot be seeded, so we can't really unit test this part of code. What we can do, however, is use property based testing to fuzzy test the generator and verify if the output is always valid.
We can check validity by passing the output to generadeReadableExpression and expect it to NOT throw.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5