Skip to content

Change endpoint and update Jest configuration and tests #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Change endpoint and update Jest configuration and tests #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bad17d0
Change endpoint and update Jest configuration and tests
yryuvraj Nov 15, 2023
8914d3d
Fix Jest Tests
yryuvraj Nov 16, 2023
550ea7d
Implement changes
yryuvraj Nov 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
135 changes: 135 additions & 0 deletions __tests__/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,135 @@
import request from 'supertest';
import express from 'express';

const app = express();

import { generateCronExpression, generateReadableExpression } from '../src/cronGenerator';

app.get('/v1/generate', (req, res) => {
Copy link

@arvindpunk arvindpunk Nov 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not duplicate server code! (remember, DRY (don't repeat yourself)

Refer to the guide mentioned in jest docs.

const cronExpression = generateCronExpression();

let readableExpression: string;
try {
readableExpression = generateReadableExpression(cronExpression);
}
catch (error: any) {
console.error(`Error generating readable expression: ${error.message}`);
readableExpression = 'Invalid expression';
}

res.json({
expression: cronExpression,
readableExpression: readableExpression,
});
});

describe('GET /v1/generate', () => {
it('should return a predefined readableExpression for a known cronExpression', async () => {
const knownCronExpression = '22 4 * *';
const knownReadableExpression = 'Every minute, between 4:22 AM and 4:22 AM, on every day';

jest.spyOn(require('../src/cronGenerator'), 'generateCronExpression').mockReturnValue(knownCronExpression);
jest.spyOn(require('../src/cronGenerator'), 'generateReadableExpression').mockReturnValue(knownReadableExpression);

const response = await request(app).get('/v1/generate');

expect(response.status).toBe(200);
expect(response.body).toHaveProperty('expression', knownCronExpression);
expect(response.body).toHaveProperty('readableExpression', knownReadableExpression);
});

it('should return a predefined readableExpression for a random cronExpression', async () => {
const randomMinute = Math.floor(Math.random() * 60);
const randomHour = Math.floor(Math.random() * 24);
const randomDayOfWeek = Math.floor(Math.random() * 7);

const randomCronExpression = `${randomMinute} ${randomHour} * * ${randomDayOfWeek}`;
const expectedReadableExpression = `Every ${randomMinute} minutes, at ${randomHour}:00, on every day`;

jest.spyOn(require('../src/cronGenerator'), 'generateCronExpression').mockReturnValue(randomCronExpression);
jest.spyOn(require('../src/cronGenerator'), 'generateReadableExpression').mockReturnValue(expectedReadableExpression);

const response = await request(app).get('/v1/generate');

expect(response.status).toBe(200);
expect(response.body).toHaveProperty('expression', randomCronExpression);
expect(response.body).toHaveProperty('readableExpression', expectedReadableExpression);
});

it('should return a predefined readableExpression for another random cronExpression', async () => {
const randomMinute = Math.floor(Math.random() * 60);
const randomHour = Math.floor(Math.random() * 24);
const randomDayOfMonth = Math.floor(Math.random() * 31) + 1; // Adding 1 to not get day 0
const randomMonth = Math.floor(Math.random() * 12) + 1;
const randomDayOfWeek = Math.floor(Math.random() * 7);

const randomCronExpression = `${randomMinute} ${randomHour} ${randomDayOfMonth} ${randomMonth} ${randomDayOfWeek}`;
const expectedReadableExpression = `Every ${randomMinute} minutes, at ${randomHour}:00, on day ${randomDayOfMonth} of month ${randomMonth}, on every day`;

jest.spyOn(require('../src/cronGenerator'), 'generateCronExpression').mockReturnValue(randomCronExpression);
jest.spyOn(require('../src/cronGenerator'), 'generateReadableExpression').mockReturnValue(expectedReadableExpression);

const response = await request(app).get('/v1/generate');

expect(response.status).toBe(200);
expect(response.body).toHaveProperty('expression', randomCronExpression);
expect(response.body).toHaveProperty('readableExpression', expectedReadableExpression);
});

it('should return a predefined readableExpression for yet another random cronExpression', async () => {
const randomMinute = Math.floor(Math.random() * 60);
const randomHour = Math.floor(Math.random() * 24);
const randomMonth = Math.floor(Math.random() * 12) + 1;
const randomDayOfWeek = Math.floor(Math.random() * 7);

const randomCronExpression = `${randomMinute} ${randomHour} * ${randomMonth} ${randomDayOfWeek}`;
const expectedReadableExpression = `Every ${randomMinute} minutes, at ${randomHour}:00, on every day, in month ${randomMonth}, on every day`;

jest.spyOn(require('../src/cronGenerator'), 'generateCronExpression').mockReturnValue(randomCronExpression);
jest.spyOn(require('../src/cronGenerator'), 'generateReadableExpression').mockReturnValue(expectedReadableExpression);

const response = await request(app).get('/v1/generate');

expect(response.status).toBe(200);
expect(response.body).toHaveProperty('expression', randomCronExpression);
expect(response.body).toHaveProperty('readableExpression', expectedReadableExpression);
});

it('should return a predefined readableExpression for a different random cronExpression', async () => {
const randomMinute = Math.floor(Math.random() * 60);
const randomHour = Math.floor(Math.random() * 24);
const randomDayOfMonth = Math.floor(Math.random() * 31) + 1;
const randomMonth = Math.floor(Math.random() * 12) + 1;

const randomCronExpression = `${randomMinute} ${randomHour} ${randomDayOfMonth} ${randomMonth} *`;
const expectedReadableExpression = `Every ${randomMinute} minutes, at ${randomHour}:00, on day ${randomDayOfMonth} of month ${randomMonth}, on every day`;

jest.spyOn(require('../src/cronGenerator'), 'generateCronExpression').mockReturnValue(randomCronExpression);
jest.spyOn(require('../src/cronGenerator'), 'generateReadableExpression').mockReturnValue(expectedReadableExpression);

const response = await request(app).get('/v1/generate');

expect(response.status).toBe(200);
expect(response.body).toHaveProperty('expression', randomCronExpression);
expect(response.body).toHaveProperty('readableExpression', expectedReadableExpression);
});

it('should return a predefined readableExpression for another different random cronExpression', async () => {
const randomMinute = Math.floor(Math.random() * 60);
const randomHour = Math.floor(Math.random() * 24);
const randomMonth = Math.floor(Math.random() * 12) + 1;
const randomDayOfWeek = Math.floor(Math.random() * 7);

const randomCronExpression = `${randomMinute} ${randomHour} * ${randomMonth} ${randomDayOfWeek}`;
const expectedReadableExpression = `Every ${randomMinute} minutes, at ${randomHour}:00, on every day, in month ${randomMonth}, on every day`;

jest.spyOn(require('../src/cronGenerator'), 'generateCronExpression').mockReturnValue(randomCronExpression);
jest.spyOn(require('../src/cronGenerator'), 'generateReadableExpression').mockReturnValue(expectedReadableExpression);

const response = await request(app).get('/v1/generate');

expect(response.status).toBe(200);
expect(response.body).toHaveProperty('expression', randomCronExpression);
expect(response.body).toHaveProperty('readableExpression', expectedReadableExpression);
});
});
Loading