Skip to content

Assignment 2 completed#2

Open
oshmen71 wants to merge 5 commits into
mainfrom
assignemnt
Open

Assignment 2 completed#2
oshmen71 wants to merge 5 commits into
mainfrom
assignemnt

Conversation

@oshmen71
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Python code to analyse data set

What did you learn from the changes you have made?

Regression concepts

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Practice personally

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

errors in codes, google

How were these changes tested?

run code and test with the assignment guide

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@fyellow fyellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You’re close, but a couple of things to fix:
Don’t rename your predictors to feature_0, feature_1, etc. keep the original column names so the coefficients are interpretable.

The sklearn warning is happening because you fitted with a DataFrame that has column names, but predicted with raw arrays. Keep the feature names consistent between training and testing.

@oshmen71 oshmen71 requested a review from fyellow September 20, 2025 15:31
@fyellow
Copy link
Copy Markdown

fyellow commented Sep 22, 2025

Assignment 2 is complete, please note that you have assignment 3 in the same pull request

Copy link
Copy Markdown

@DwardEE DwardEE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Everything seems correct. However, you did not answer the reflection question (“What method to determine optimal k?”).

Please give a short response and resubmit the completed assignment.

@oshmen71
Copy link
Copy Markdown
Owner Author

Great work!

Everything seems correct. However, you did not answer the reflection question (“What method to determine optimal k?”).

Please give a short response and resubmit the completed assignment.

Hi new pull request #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants