Skip to content

Created function signature and testsuite for the buildTypeWeightsFromSchemaObject function #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
May 21, 2022
Merged

Created function signature and testsuite for the buildTypeWeightsFromSchemaObject function #14

merged 18 commits into from
May 21, 2022

Conversation

@evanmcneely
Copy link
Contributor

@evanmcneely evanmcneely commented May 20, 2022 •
edited
Loading

Summary

  • created the function signature for the buildTypeWeightsFromSchemaObject function. This function will iterate through the schema object and create a "type weights" object for use in the complexity algorithm.
  • wrote a test suite to check functionality of the above function.

Type of Change

  • New feature (non-breaking change which adds functionality)

Issues

closes #7

Evidence

'query parameter' is skipped because we opted not to implement that as a default configuration but could at a later date.

Screen Shot 2022-05-19 at 10 16 30 PM

shalarewicz and others added 13 commits May 17, 2022 15:38
@shalarewicz
intitial jest and typescript config
07d76bc
@shalarewicz
RateLimiter spec closes #9. Test for token bucket algorithm closes #4.
0656e58
@shalarewicz
updated test script to pass without any tests
778f0a6
@evanmcneely
resolving some errors with eslint and ts
37012d2
@evanmcneely
Created types and function definitions for the get type weights function
2aaf2f4
@evanmcneely
renamed the file to buildTypeWeights
7973e37
@evanmcneely
started to layout the test structure for buildTypeWeight function
7f5f655
@evanmcneely
added a default type weights configuration to the function parameters
094847e
@evanmcneely
moved types to @types folder
06a119c
@evanmcneely
wrote tests for buildTypeWeights functionality and configurability
f3c1118
@evanmcneely
added some tests and reworked expected output
96ab047
@evanmcneely
finish writing and proof reading tests
43e0dd2
@evanmcneely
finished writing an overview of implementation for buildTypeWeightsFr…
7b05588 
…omSchema function
shalarewicz
shalarewicz reviewed May 21, 2022
View reviewed changes
Copy link
Collaborator

@shalarewicz shalarewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor comments. Is there any additional testing that can be done with nesting? Not sure if there is but wanted to bring it up.

@evanmcneely evanmcneely requested a review from shalarewicz May 21, 2022 17:01
milos381
milos381 approved these changes May 21, 2022
View reviewed changes
Copy link

@milos381 milos381 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Well written. Completely understandable and readable.

@evanmcneely evanmcneely merged commit 2f838b8 into dev May 21, 2022
@shalarewicz shalarewicz mentioned this pull request May 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shalarewicz shalarewicz shalarewicz approved these changes

@milos381 milos381 milos381 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Write test for graphql schema object parser function

4 participants

@evanmcneely @shalarewicz @milos381