initial framework and spec for express rate limiting middleware. #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jondeweydev
approved these changes
May 21, 2022
Collaborator
jondeweydev
left a comment
jondeweydev
left a comment
There was a problem hiding this comment.
Great comments, you're setting an example for my future pseudocode.
feiw101
approved these changes
May 21, 2022
evanmcneely
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Establishes an initial framework for an Express Rate Limiting middleware generator. Users can specify the type of rate limiting algorithm and provide custom type weights for their schema through a
TypeWeightConfigobject.To cache rate limiting information for each user, redis client connection information must be provided. Otherwise a redis client will be created at
localhost:6379Type of Change
Issues
Evidence
-N/A this is just a specification. The middleware function has not been implemented.