Extended test suite of 'typeWeightObject' to account for lists, enums, interfaces and unions

[evanmcneely]

Summary

Changes are not 100% ready but I am requesting feedback and input on 1 particular problem I am having.

When working with lists in graphQL, the type complexity of the query is dependent on the number of objects returned in the list. For example, on line 190 in buildTypeWeights.test.ts:

'type Query {
     reviews(episode: Episode!, first: Int): [Review]
}'

the field reviews is a list, with the number of reviews included in the response dependent on the argument passed in for first. If first is 3 than the type complexity of the reviews field in the query is 3, since it returns 3 Review objects in the response. The challenge is how to represent this in the typeWeightsObject (if it should be). I currently have the expected field weight for the Review type set to 1. Maybe this is something the complexity algorithm should deal with since it knows the argument passed in to first?

Type of Change

• New feature (non-breaking change which adds functionality)

Issues

• closes Extend the test suite for 'buildTypeWeights' function to account for LISTS, ENUMS, INTERFACES, UNIONS, INPUT TYPES in a schema object #21

Evidence

[shalarewicz]

Great work! Left a few comments. We can discuss further if needed.

[jondeweydev]

I wish I could add any insight, if we can find time to quickly talk through the code, perhaps I can add another perspective, but as of reading it now it looks thoughtful. I would recommend adding more comments to the code in the future