Token bucket algorithm #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n bucket accordingly
…ead of node-redis
evanmcneely
commented
May 29, 2022
…solving that problem
…raphQL-Gate into em/tokenBucketAlgo
jondeweydev
approved these changes
Jun 2, 2022
feiw101
approved these changes
Jun 2, 2022
shalarewicz
approved these changes
Jun 2, 2022
Collaborator
shalarewicz
left a comment
shalarewicz
left a comment
There was a problem hiding this comment.
Great work. Only major thing we'll need to consider moving forward is how to handle redis connection failures. Other than that just a few comments on the use of magic numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Token bucket implementation for rate limiting
Refactored algorithm and the tests to use IORedis instead of node-redis. Some of the tests were not behaving the way I believe they were intended to (small typos). I modified the tests with care. Please check the changes and flag any concerns. There is one test that I don't believe is correct and I don't know what the intention was. See line
187- `token bucket refills at specified rate'Type of Change
Issues
Evidence