Skip to content

Conversation

@evanmcneely
Copy link
Contributor

@evanmcneely evanmcneely commented May 31, 2022

Summary

This is the implementation of the rate limiting middleware. Tests are not working because typeComplexityAnalysis is not implemented in this branch. I am making issues to account for any error handling left undone and all aspects that need to be extended.

Type of Change

  • New feature (non-breaking change which adds functionality)

Issues

Evidence

No evidence. Tests are still in review ,and most of them are integration tests, so the middleware won't work without the algorithms still needing to be written.

@evanmcneely evanmcneely requested a review from shalarewicz May 31, 2022 02:25
@evanmcneely evanmcneely changed the title Draft implementation of express rate limiting middleware Implementation of express rate limiting middleware Jun 2, 2022
@evanmcneely evanmcneely marked this pull request as ready for review June 2, 2022 15:31
@evanmcneely evanmcneely requested review from feiw101 and milos381 June 2, 2022 15:32
@shalarewicz shalarewicz merged commit 3cfbef4 into dev Jun 4, 2022
@evanmcneely evanmcneely deleted the em/middleware branch June 20, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Express Middleware Producer

4 participants