Add tests for non-null operators #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feiw101
approved these changes
Jul 6, 2022
…l-tests Corrected non-null test
jondeweydev
approved these changes
Jul 9, 2022
…slabs-beta/GraphQL-Gate into sh/non-null-tests
evanmcneely
reviewed
Jul 9, 2022
evanmcneely
reviewed
Jul 9, 2022
evanmcneely
reviewed
Jul 9, 2022
| }, | ||
| }, | ||
| episode: { | ||
| weight: 0, |
Contributor
There was a problem hiding this comment.
This one shouldn't have an episode property. It's not in the type definitions.
evanmcneely
requested changes
Jul 9, 2022
Contributor
evanmcneely
left a comment
evanmcneely
left a comment
There was a problem hiding this comment.
Just a few small changes to the typeWeights tests otherwise makes sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates type complexity, type weights, and weight function test suites to account for cases where a non-null operator is used in the schema as specified by #48.
Type of Change
Issues
Evidence