Skip to content

Refactored Type Weights Object to better handle lists and nesting when calculating query complexity #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Jul 9, 2022
Merged

Refactored Type Weights Object to better handle lists and nesting when calculating query complexity #66

merged 36 commits into from
Jul 9, 2022

Conversation

@evanmcneely
Copy link
Contributor

@evanmcneely evanmcneely commented Jul 6, 2022 •
edited
Loading

Summary

  1. The type weights object has been refactored to include the type that the field resolves to along with its weight where necessary
  2. As a result of the above change, the testing suites for complexity analysis and type weights were updated to reflect this new strategy
  3. The outcomes of this update are that nesting, lists, arguments and variables all have basic functionality

Some things to be aware of...

  • The expected outcome of test simple nesting should be reviewed.
  • I'm unsure if the new type weights object structure can handle Unions properly since the union doesn't have fields and has no reference for where to look for the fields.
  • scalar lists and lists of enums need to be reviewed

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Issues

closes #62
closes #60
closes #58
closes #63

Evidence

Screen Shot 2022-07-06 at 10 30 30 AM
Screen Shot 2022-07-06 at 10 30 53 AM
Screen Shot 2022-07-06 at 10 31 01 AM

evanmcneely added 26 commits June 30, 2022 09:47
@evanmcneely
removed unessesary arguments from parseTypes
25a28b0
@evanmcneely
updated function name pareOuery to parseQueryType
c2e8a64
@evanmcneely
added functionality to calculate complexity of lists with variables
8978a69
@evanmcneely
added functionality to appropiatly multiply nested lists
341e2ae
@evanmcneely
testing new functionality. waiting for updated tests
a2ba5ef
@evanmcneely
merged changes from sh/test-suite-updates and fixed confilcts
e18da20
@evanmcneely
refactored the complexity analysis to handle nesting properly. Not pa…
f7cd3e2 
…ssing tests at the moment
@evanmcneely
Merge branch 'dev' of https://github.com/oslabs-beta/GraphQL-Gate int…
d036acb 
…o em/variables
@evanmcneely
test with one level of nesting is passing
cb0bc66
@evanmcneely
activated all the tests that need to pass
34d834d
@evanmcneely
updated the way nested queries are adding or subtracting values to pa…
266ccea 
…ss tests. Uncovering some other deep problems in our setup that will have to be addressed moving forward
@evanmcneely
started to refactor type weights object
31bcb99
@evanmcneely
refactored typeWeightObject tests to have refernces to their types
cd7f6c2
@evanmcneely
making progress on the refactoring of buildTypeWeights. a few more ty…
69d1cc6 
…pes that need to be accounted for
@evanmcneely
got all the tests working and refactoring the code to be more dry
a5e51c3
@evanmcneely
refactored the typeWeightsObject to include reference to the resolved…
551f2ae 
… type. passing updated tests
@evanmcneely
refactored complexity tests to work with new typeWeightsObject and pa…
2e451f9 
…ssing tests
@evanmcneely
refactored the typeComplexity field node function to be more readable
956a7c3
@evanmcneely
refactored buildTypeWeights parseObjectFields to be mroe readable
908941b
@evanmcneely
refactored lists returning scalar values to only compound if the scal…
de07e93 
…ar eight is above 0
@evanmcneely
added a few more comments to buildTypeWeights
69e31f5
@evanmcneely
Refactored the weightFunction calculating list weight to take in the …
367a05f 
…selection cost and handle the everything involved with calculating field weights
@evanmcneely
small edits after reviewing typeComplexity tests
31c1144
@evanmcneely
small edits after reviewing buildTypeWeights tests
66783a7
@evanmcneely
weightFunction woring with default arguments in the schema
742687f
@evanmcneely
added one comment to the weightFunction
25e4cde
@evanmcneely evanmcneely mentioned this pull request Jul 6, 2022
Closed
shalarewicz
shalarewicz reviewed Jul 7, 2022
View reviewed changes
@evanmcneely evanmcneely requested a review from shalarewicz July 7, 2022 18:51
shalarewicz
shalarewicz reviewed Jul 8, 2022
View reviewed changes
Copy link
Collaborator

@shalarewicz shalarewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one commend on the test case with object weight = 0

shalarewicz
shalarewicz approved these changes Jul 9, 2022
View reviewed changes
Copy link
Collaborator

@shalarewicz shalarewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! No further comments.

@evanmcneely evanmcneely merged commit 8d594cb into dev Jul 9, 2022
@evanmcneely evanmcneely deleted the em/lists-variables-nesting-refactoring branch August 1, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shalarewicz shalarewicz shalarewicz approved these changes

@jondeweydev jondeweydev jondeweydev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

4 participants

@evanmcneely @shalarewicz @jondeweydev