SlidingWindowCounter testing suite #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I am going to set all the tests to skip so that Travis does not fail on this PR |
evanmcneely
reviewed
Jul 14, 2022
evanmcneely
reviewed
Jul 14, 2022
shalarewicz
requested changes
Jul 16, 2022
Collaborator
There was a problem hiding this comment.
The tests seems reasonable for the most part. I think that they can benefit from
- additional assertions for success on the rate limiter response,
- clearer test names (e.g. fixed window is full => previous window is full)
- some additional tests for edge cases unique to sliding window.
There's a good chance I misinterpreted one of the tests. If you disagree/have questions let me know and we can discuss in person.
Good work!
shalarewicz
reviewed
Jul 16, 2022
shalarewicz
reviewed
Jul 16, 2022
…o jd/slideTest
…-Gate into jd/slideTest
evanmcneely
approved these changes
Jul 22, 2022
Contributor
evanmcneely
left a comment
evanmcneely
left a comment
There was a problem hiding this comment.
I did not go through all the math involved to check the expected results of the overlapping sliding window tests. This looks thorough and and covers all cases I can think about.
shalarewicz
approved these changes
Jul 25, 2022
Collaborator
shalarewicz
left a comment
shalarewicz
left a comment
There was a problem hiding this comment.
Looks good! Great work. This should give us pretty thorough coverage.
Collaborator
Author
|
Closes #78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Took TokenBucket tests as a template and added/removed a few tests specific to each limiting algorithm, respectively.
Type of Change
Issues
#70