Skip to content

Implementation of non-null types and improvments for unions in the schema parsing #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 27, 2022
Merged

Implementation of non-null types and improvments for unions in the schema parsing #85

merged 7 commits into from
Jul 27, 2022

Conversation

@evanmcneely
Copy link
Contributor

@evanmcneely evanmcneely commented Jul 19, 2022 •
edited
Loading

Summary

passing test for non-null types in type weights and weight function tests

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Issues

closes #48

Evidence

Screen Shot 2022-07-19 at 2 54 57 PM
Screen Shot 2022-07-19 at 2 55 20 PM

@evanmcneely evanmcneely changed the title Implementation of non-null types in the schema definition Implementation of non-null types in the schema parsing Jul 19, 2022
shalarewicz
shalarewicz reviewed Jul 19, 2022
View reviewed changes
Copy link
Collaborator

@shalarewicz shalarewicz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Do you want to handle the cases introduced by #77 when handling union types as well? Some additional tests will need to be written

@evanmcneely evanmcneely requested a review from shalarewicz July 20, 2022 16:23
@evanmcneely
Copy link
Contributor Author

evanmcneely commented Jul 20, 2022

I've added tests and additional functionality for unions with non-null, object and enum types. Let me know if you think of any other cases that need to be accounted for.

@evanmcneely evanmcneely changed the title Implementation of non-null types in the schema parsing Implementation of non-null types and improvments for unions in the schema parsing Jul 20, 2022
shalarewicz
shalarewicz requested changes Jul 25, 2022
View reviewed changes
@evanmcneely evanmcneely requested a review from shalarewicz July 26, 2022 02:17
@evanmcneely evanmcneely merged commit 24fa089 into dev Jul 27, 2022
@evanmcneely evanmcneely deleted the em/nonNull branch July 27, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shalarewicz shalarewicz shalarewicz approved these changes

@jondeweydev jondeweydev jondeweydev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle GraphQL Non-null wrappers in tests and implementation

4 participants

@evanmcneely @shalarewicz @jondeweydev